Move FileIO support into extension #1166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
topolarity
force-pushed
the
ct/fileio-ext
branch
from
a1ceb1b
to
6416915
Compare
topolarity
force-pushed
the
ct/fileio-ext
branch
from
6416915
to
16a1d73
Compare
|
Invalidations check appears to be an unrelated failure |
|
@simonbyrne @musm any thoughts about this pull request? Does this require a version bump? |
simonbyrne
approved these changes
Oct 16, 2024
|
I will try to sort these out this weekend. |
|
I'm leaning towards dropping Requires entirely with 0.18 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves one of the two remaining uses of Requires.jl into a pair of extensions.