Add pledgeinsize
#64
Open
Add pledgeinsize
#64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #64 +/- ##
==========================================
+ Coverage 61.35% 63.56% +2.21%
==========================================
Files 5 5
Lines 370 376 +6
==========================================
+ Hits 227 239 +12
+ Misses 143 137 -6 ☔ View full report in Codecov by Sentry. |
nhz2
commented
Oct 5, 2024
| @@ -31,6 +31,7 @@ jobs: | |||
| Pkg.Registry.update() | |||
| Pkg.activate(;temp=true) | |||
| # force it to use this PR's version of the package | |||
| ENV["JULIA_PKG_DEVDIR"]= mktempdir() | |||
There was a problem hiding this comment.
This ensures fresh versions of the developed packages, in case this is run locally.
| end | ||
|
|
||
| function TranscodingStreams.process(codec::ZstdCompressor, input::Memory, output::Memory, error::Error) | ||
| if codec.cstream.ptr == C_NULL | ||
| error("startproc must be called before process") | ||
| Base.error("`startproc` must be called before `process`") |
There was a problem hiding this comment.
error is the name of a local variable, so I need to specify Base.error here.
| s = TranscodingStream(codec(), sink; stop_on_end=true) | ||
| write(s, b"Hello") | ||
| close(s) | ||
| buffer3 = take!(sink) | ||
| @test CodecZstd.find_decompressed_size(buffer3) == CodecZstd.ZSTD_CONTENTSIZE_UNKNOWN |
There was a problem hiding this comment.
transcode with ZstdCompressor now records the decompressed size.
mkitti
requested changes
Oct 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of JuliaIO/TranscodingStreams.jl#239
This PR reduces the allocations needed when decompressing data compressed with
transcode.For example:
With this PR and JuliaIO/TranscodingStreams.jl#239:
416.579 ns (4 allocations: 10.05 KiB)
Before:
510.451 ns (5 allocations: 19.72 KiB)