Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docstring corrections and suggestion #2

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

guiyrt
Copy link

@guiyrt guiyrt commented Oct 2, 2024

  • Correction in differential_cross_section docstring, adding term $\frac{\rho_\mu}{\rho_e}$
  • Correction in minkowski_dot docstring, + signal replaced with -
  • Suggestion based on notebook1 content, adding more context in coords_to_dict docstring. As a non-physicist, it was already somewhat difficult to get there with the added context 😁

Great work on the material!! 👍

@aoanla
Copy link

aoanla commented Oct 3, 2024

Just my 2¢/€, I agree with these changes - I have a list of places that need more context from discussions during the session (including with @guiyrt ) which includes all of these and a few more that I missed from the notebooks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants