Added inPolygon with tests #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boriskaus
previously approved these changes
Mar 6, 2024
src/utils.jl
Outdated
| Checks if points given by matrices `X` and `Y` are in or on (both cases return true) a polygon given by `PolyX` and `PolyY`. Boolean `fast` will trigger faster version that may miss points that are exactly on the edge of the polygon. Speedup is a factor of 3. | ||
|
|
||
| """ | ||
| function inPolygon!(PolyX::Vector{T}, PolyY::Vector{T}, X::Matrix{T}, Y::Matrix{T}, INSIDE::Matrix{Bool}; fast=false) where T <: Real |
There was a problem hiding this comment.
the naming convention for in-place Julia functions is that the array that is being changed should be listed first.
So this should be renamed as:
function inPolygon!(INSIDE::Matrix{Bool}, PolyX::Vector{T}, PolyY::Vector{T}, X::Matrix{T}, Y::Matrix{T}; fast=false) where T <: RealThere was a problem hiding this comment.
I changed it around but now one of the tests failed. It says it is in IO and sounds like a network problem of the test server. Do you understand what is going on there?
There was a problem hiding this comment.
yes, we have this frequently. Downloading remote data is sometimes fragile. restarting the CI often solves it.
boriskaus
dismissed
their stale review
I accidentally approved; the input to the function should be renamed
boriskaus
requested changes
Mar 6, 2024
boriskaus
approved these changes
Mar 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added inpolygon function which is needed for the setup generation of Tatjana/Andrea