Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Polygon structure in pseudo3D #73

Merged
merged 26 commits into from
Mar 13, 2024

Conversation

TatjanaWeiler
Copy link
Contributor

inPoly function is not final yet

@boriskaus
Copy link
Member

boriskaus commented Mar 2, 2024

This generally looks fine to me. I've changed the name of the function to address issue #77
A few additional additions are required:

  1. Please add help info to the function by using the """ ... """ before the function (see AddBox! for example).
  2. Please add a test for this, as part of the test suite in test_setup_geometry.jl
  3. Can you expand the tutorial to a real tutorial by adding some more info? You can use Literate.jl to create a markdown file from this and add one of more figures. Tutorials are under docs/src/man with images under docs/src/assets/img. Also add the new tutorial in the docs/make.jl file and it will appear in the sidebar of the tutorials. As an example for this, you can have a look at tutorials/Tutorial_Jura.jl

@boriskaus
Copy link
Member

What’s the current status of this? Is it finished?

@boriskaus boriskaus merged commit e915540 into JuliaGeodynamics:main Mar 13, 2024
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants