-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more kernels to the benchmark and AD benchmarks #434
base: master
Are you sure you want to change the base?
Conversation
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Shall we just stick with Zygote for now? I'm not going to have a chance to look at the above ParameterHandling PR for a while, and it needs some proper thought to ensure that it doesn't mess up anything else. The performance of ForwardDiff is, in general in my (limited) experience, more robust and closely linked to primal performance than Zygote anyway, so I'm less concerned about it (I might be horribly wrong though). |
Codecov Report
@@ Coverage Diff @@
## master #434 +/- ##
=======================================
Coverage 92.99% 92.99%
=======================================
Files 52 52
Lines 1214 1214
=======================================
Hits 1129 1129
Misses 85 85 Continue to review full report at Codecov.
|
…s/KernelFunctions.jl into tgf/add_benchmarks
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Benchmark resultJudge resultBenchmark Report for /home/runner/work/KernelFunctions.jl/KernelFunctions.jlJob Properties
ResultsA ratio greater than
Benchmark Group ListHere's a list of all the benchmark groups executed by this job: Julia versioninfoTarget
Baseline
Target resultBenchmark Report for /home/runner/work/KernelFunctions.jl/KernelFunctions.jlJob Properties
ResultsBelow is a table of this job's results, obtained by running the benchmarks.
Benchmark Group ListHere's a list of all the benchmark groups executed by this job:
Julia versioninfo
Baseline resultBenchmark Report for /home/runner/work/KernelFunctions.jl/KernelFunctions.jlJob Properties
ResultsBelow is a table of this job's results, obtained by running the benchmarks.
Benchmark Group ListHere's a list of all the benchmark groups executed by this job:
Julia versioninfo
Runtime information
|
Adds a pair more kernels and benchmarks for AD
Right now the issue is with ForwardDiff where I am not sure how to turn the parameters into a single
Array
, if we want to useParameterHandling
we first need JuliaGaussianProcesses/ParameterHandling.jl#39 to be merged.