Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial proof-of-concept Expectation Propagation #64

Open
wants to merge 113 commits into
base: master
Choose a base branch
from

Conversation

st--
Copy link
Member

@st-- st-- commented Oct 1, 2021

This is a very basic version to demonstrate proof-of-concept. See #92 for missing features.

@st-- st-- mentioned this pull request Jan 11, 2022
src/ep.jl Outdated Show resolved Hide resolved
src/laplace.jl Outdated Show resolved Hide resolved
st-- and others added 5 commits January 11, 2022 11:39
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…rocesses/ApproximateGPs.jl into st/ExpectationPropagation
src/ep.jl Outdated Show resolved Hide resolved
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@st-- st-- changed the title Expectation Propagation Initial proof-of-concept Expectation Propagation Jan 11, 2022
@st-- st-- requested a review from theogf January 13, 2022 08:47
@st--
Copy link
Member Author

st-- commented Jan 13, 2022

Why are the tests failing when all I did was merge in master (with #76)? 😢

@devmotion
Copy link
Member

devmotion commented Jan 13, 2022

Caused by JuliaDiff/ChainRules.jl#559 it seems (similar to issues in Distributions, DistributionsAD, NNlib etc.). Should be fixed by the new ChainRules release (bugfix was JuliaDiff/ChainRules.jl#562).

src/ep.jl Outdated Show resolved Hide resolved
st-- and others added 2 commits January 14, 2022 10:39
@st--
Copy link
Member Author

st-- commented Jan 14, 2022

Caused by JuliaDiff/ChainRules.jl#559 it seems (similar to issues in Distributions, DistributionsAD, NNlib etc.). Should be fixed by the new ChainRules release (bugfix was JuliaDiff/ChainRules.jl#562).

Thanks @devmotion ! it seems to be passing again :)

@st--
Copy link
Member Author

st-- commented Jan 18, 2022

@theogf what do you think of this as a first stab ?

test/ExpectationPropagationModule.jl Outdated Show resolved Hide resolved
test/runtests.jl Outdated Show resolved Hide resolved
st-- and others added 2 commits March 21, 2022 09:30
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants