Mandate non-broken versions of GPUCompiler #411
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christiangnrd
changed the title
tgymnich
approved these changes
Aug 29, 2024
|
Hmm, I'm not entirely convinced. Strictly speaking, lots of code was still working fine on the older versions of GPUCompiler, so this isn't a real "compatibility" issue. I'm also afraid that the strict LLVM requirement (imposed indirectly by GPUCompiler) will conflict with users' environments, forcing a downgrade of Metal.jl instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many subtle bugs were fixed between GPUCompiler v0.26 and v0.27.4, so prevent those bugs by making v0.27.4 necessary.
It also seems like GPUCompiler v0.27.4 either solves or works around #401. So this would potentially close that issue too.