Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MPS solve #145

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

MPS solve #145

wants to merge 4 commits into from

Conversation

tgymnich
Copy link
Member

@tgymnich tgymnich commented Mar 22, 2023 •
edited by christiangnrd
Loading

Closes #402

@tgymnich
Copy link
Member Author

tgymnich commented Mar 31, 2023 •
edited
Loading

I seem to be getting blocks of NaNs when solving systems larger than 128x128. Weird....

@tgymnich tgymnich force-pushed the mps-solve branch 3 times, most recently from 5ab3330 to 80af119 Compare March 31, 2023 19:12
@maleadt maleadt added libraries Things about libraries and how we use them. arrays Things about the array abstraction. enhancement labels May 22, 2023
@tgymnich tgymnich force-pushed the mps-solve branch 2 times, most recently from c8d4a9e to af07cd6 Compare September 5, 2023 14:05
@tgymnich tgymnich mentioned this pull request Apr 10, 2024
Closed
@jpsamaroo
Copy link
Member

@tgymnich did you ever resolve the NaN issue? @Rabab53 has also been encountering these while trying to use the MPS triangular solve.

@tgymnich
Copy link
Member Author

tgymnich commented Jul 2, 2024 •
edited
Loading

@jpsamaroo I have looked into it recently and the error still seems to be present.

@tgymnich tgymnich mentioned this pull request Jul 5, 2024
Open
@tgymnich tgymnich mentioned this pull request Jul 27, 2024
Open
@maleadt maleadt force-pushed the main branch 2 times, most recently from 5a8daaa to b9610e3 Compare December 19, 2024 08:12
@christiangnrd
Copy link
Contributor

christiangnrd commented Feb 8, 2025 •
edited
Loading

Same problems, new base :)

BTW, these tests also fail for CPU Arrays.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
arrays Things about the array abstraction. blocked libraries Things about libraries and how we use them.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement MPSMatrixSolve
4 participants
@tgymnich @jpsamaroo @christiangnrd @maleadt