Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update New PassManager Pipeline #559

Merged
merged 3 commits into from
Apr 10, 2024
Merged

Update New PassManager Pipeline #559

merged 3 commits into from
Apr 10, 2024

Conversation

vchuravy
Copy link
Member

@vchuravy vchuravy commented Apr 5, 2024

I compared Julia's native PM with the definitions here
while looking at JuliaGPU/CUDA.jl#2313

The generated IR in the issue seems equivalent, but the
result of the optimization pipeline differs.

Copy link

codecov bot commented Apr 5, 2024

Codecov Report

Attention: Patch coverage is 94.11765% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 82.83%. Comparing base (3c1bc65) to head (0a73ecb).
Report is 10 commits behind head on master.

Files Patch % Lines
src/optim.jl 94.11% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #559      +/-   ##
==========================================
+ Coverage   82.39%   82.83%   +0.44%     
==========================================
  Files          24       24              
  Lines        3334     3572     +238     
==========================================
+ Hits         2747     2959     +212     
- Misses        587      613      +26     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vchuravy vchuravy requested a review from maleadt April 9, 2024 14:26
@vchuravy
Copy link
Member Author

vchuravy commented Apr 9, 2024

cc: @pchintalapudi @gbaraldi for your pipeline expertise.

@vchuravy vchuravy merged commit cb736ee into master Apr 10, 2024
21 checks passed
@vchuravy vchuravy deleted the vc/newpm_updates branch April 10, 2024 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant