Skip to content

KernelAbstractions 0.10 compat #592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 8 commits into
base: master
Choose a base branch
from
Draft

KernelAbstractions 0.10 compat #592

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
416b28f
Faster matmul
christiangnrd Apr 11, 2025
f61e6bb
KA 0.10 compat
christiangnrd May 12, 2025
1b7728d
Don't test JLArrays
christiangnrd May 12, 2025
63aa464
Revert "Faster matmul"
christiangnrd May 13, 2025
07fbb88
ytd
christiangnrd May 13, 2025
007466e
esthr
christiangnrd May 13, 2025
5b07947
hsgff
christiangnrd May 14, 2025
113448c
jrgfdsh
christiangnrd May 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions .github/workflows/Test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,10 +26,11 @@ jobs:
- uses: julia-actions/cache@v2
- name: Develop subpackages
run: |
julia --project -e "
julia --project -e '
using Pkg
Pkg.develop("KernelAbstractions")
Pkg.develop([PackageSpec(; name=basename(path), path) for path in ARGS])
" lib/GPUArraysCore lib/JLArrays
' lib/GPUArraysCore
- uses: julia-actions/julia-runtest@v1
continue-on-error: ${{ matrix.version == 'nightly' }}
- uses: julia-actions/julia-processcoverage@v1
Expand Down
2 changes: 1 addition & 1 deletion Project.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ Statistics = "10745b16-79ce-11e8-11f9-7d13ad32a3b2"
[compat]
Adapt = "4.0"
GPUArraysCore = "= 0.2.0"
KernelAbstractions = "0.9.28"
KernelAbstractions = "0.10"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should be able to say 0.9.28, 0.10

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made it 0.10 only for testing because it requires less attention to notice that it errored than to verify that KA is actually using 0.10.

I’ll be re-adding it once it’s closer to being ready to merge.

LLVM = "3.9, 4, 5, 6, 7, 8, 9"
LinearAlgebra = "1"
Printf = "1"
Expand Down
1 change: 0 additions & 1 deletion test/Project.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
Adapt = "79e6a3ab-5dfb-504d-930d-738a2a938a0e"
Dates = "ade2ca70-3891-5945-98fb-dc099432e06a"
Distributed = "8ba89e20-285c-5b6f-9357-94700520ee1b"
JLArrays = "27aeb0d3-9eb9-45fb-866b-73c2ecf80fcb"
KernelAbstractions = "63c18a36-062a-441e-b654-da1e3ab1ce7c"
LinearAlgebra = "37e2e46d-f89d-539d-b4ee-838fcccc9c8e"
Pkg = "44cfe95a-1eb2-52ea-b672-e2afdf69b78f"
Expand Down
6 changes: 5 additions & 1 deletion test/runtests.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,12 @@
using Pkg
Pkg.develop("KernelAbstractions")

using Distributed
using Dates
import REPL
using Printf: @sprintf


# parse some command-line arguments
function extract_flag!(args, flag, default=nothing)
for f in args
Expand Down Expand Up @@ -47,7 +51,7 @@ include("setup.jl") # make sure everything is precompiled
# choose tests
const tests = []
const test_runners = Dict()
for AT in (JLArray, Array), name in keys(TestSuite.tests)
for AT in (Array,), name in keys(TestSuite.tests)
push!(tests, "$(AT)/$name")
test_runners["$(AT)/$name"] = ()->TestSuite.tests[name](AT)
end
Expand Down
6 changes: 3 additions & 3 deletions test/setup.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
using Distributed, Test, JLArrays
using Distributed, Test

include("testsuite.jl")

Expand All @@ -15,7 +15,7 @@ function runtests(f, name)
# generate a temporary module to execute the tests in
mod_name = Symbol("Test", rand(1:100), "Main_", replace(name, '/' => '_'))
mod = @eval(Main, module $mod_name end)
@eval(mod, using Test, Random, JLArrays)
@eval(mod, using Test, Random)

let id = myid()
wait(@spawnat 1 print_testworker_started(name, id))
Expand All @@ -24,7 +24,7 @@ function runtests(f, name)
ex = quote
GC.gc(true)
Random.seed!(1)
JLArrays.allowscalar(false)
# JLArrays.allowscalar(false)

@timed @testset $"$name" begin
$f()
Expand Down
Loading