This repository was archived by the owner on Nov 18, 2020. It is now read-only.
Implement decent kernel exceptions #67
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added simple hostcall for malloc, and test Added execution control intrinsics Expanded ROCModule to contain exception ring buffer Added HSAStatusSignal for exception handling
Implement working malloc and free Added memcpy! and memset! intrinsics Added more efficient memcpy! implementation for output
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, Julia exceptions trigger an
s_trap 2, which causes thewaithandler to hang, and doesn't communicate any useful information about what caused the exception. This PR replaces that mechanism with a similar mechanism to the one CUDAnative uses, but with the goal to provide proper per-kernel exceptions (as opposed to throwing the exception at the next API call).Todo:
@rocprintcalls to fix kernels with exceptionsfreefor malloc'd dataActually make the ring buffer a ring buffer (currently it's a list)ExceptionEntry)malloc'd data when the kernel exits by default