Strip whitespace in latexsub :exit-function #206
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the docstring for
completion-extra-properties
, thestring
passed to the:exit-function
should be the bare text to which the field was completed, but helm-mode adds an extra space at the end ofstring
. Since none of our latexsubs include whitespace, we can safely strip whitespace in the:exit-function
and work around this helm bug.I will file an upstring bug report against helm, but I think it's worth fixing quickly here since it's only a simple 3-line change.
Closes #204.
@tpapp, @giordano, or @FelipeLema could one of you review please? This fixes an extremely annoying bug for anyone using helm. @giordano, could you please double-check that this fixes the issue for you if you get a chance?