-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend tests #75
Extend tests #75
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #75 +/- ##
===========================================
+ Coverage 36.42% 83.94% +47.51%
===========================================
Files 18 15 -3
Lines 442 355 -87
===========================================
+ Hits 161 298 +137
+ Misses 281 57 -224 ☔ View full report in Codecov by Sentry. |
Let's remove |
I agree! It's done and ready for merge :) |
did you remove it also from the |
This PR ignores the files that are irrelevant for code coverage and adds new tests for:
kolmogorov_smirnov
andpermutation_entropy
src/significance/basic_stat_significance.jl
RidgeRegressionSlope
(previous version was broken and more intricate)SegmentedWindowConfig
timeseries.jl
were included in the test suite. These functions are not used so far but they will be as soon as we deal with unevenly sampled timeseries!For these tests to pass, minor changes have been made:
permutation_entropy
. I even reexport it, since many functions of this software are usable as metrics for TransitionsInTimeseries.jl.nameof(metric::RidgeRegressionSlope)
. This fixes the display ofIndicatorsChangeResults
.Finally, I added a few TODO flags and will open corresponding issues :)