Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend tests #75

Merged
merged 15 commits into from
Feb 19, 2024
Merged

Extend tests #75

merged 15 commits into from
Feb 19, 2024

Conversation

JanJereczek
Copy link
Contributor

This PR ignores the files that are irrelevant for code coverage and adds new tests for:

  • kolmogorov_smirnov and permutation_entropy
  • the methods for significance testing that are implemented in src/significance/basic_stat_significance.jl
  • RidgeRegressionSlope (previous version was broken and more intricate)
  • a full analysis using SegmentedWindowConfig
  • the (already existing) tests for timeseries.jl were included in the test suite. These functions are not used so far but they will be as soon as we deal with unevenly sampled timeseries!

For these tests to pass, minor changes have been made:

  • include ComplexityMeasure.jl in Project.toml, which is needed for permutation_entropy. I even reexport it, since many functions of this software are usable as metrics for TransitionsInTimeseries.jl.
  • add nameof(metric::RidgeRegressionSlope). This fixes the display of IndicatorsChangeResults.

Finally, I added a few TODO flags and will open corresponding issues :)

@codecov-commenter
Copy link

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (b1d3387) 36.42% compared to head (7be5c96) 83.94%.

Files Patch % Lines
src/change_metrics/slope.jl 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main      #75       +/-   ##
===========================================
+ Coverage   36.42%   83.94%   +47.51%     
===========================================
  Files          18       15        -3     
  Lines         442      355       -87     
===========================================
+ Hits          161      298      +137     
+ Misses        281       57      -224     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Datseris
Copy link
Member

  • include ComplexityMeasure.jl in Project.toml, which is needed for permutation_entropy. I even reexport it, since many functions of this software are usable as metrics for TransitionsInTimeseries.jl.

Let's remove permutation_entropy from the source code and remove the export and remove the dependency. The Logistic map example already shows how to use ComplexityMeasures.jl to compute the permutation entropy.

@JanJereczek
Copy link
Contributor Author

I agree! It's done and ready for merge :)

@Datseris
Copy link
Member

did you remove it also from the @docs block?

@Datseris Datseris merged commit 6f1b357 into main Feb 19, 2024
2 checks passed
@Datseris Datseris deleted the extend-tests branch February 19, 2024 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants