Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add quality code tests: Aqua.jl + method ambiguities test #921

Merged
merged 10 commits into from
Nov 14, 2023
Merged

Conversation

Tortar
Copy link
Member

@Tortar Tortar commented Nov 13, 2023

This resolved the 22 method ambiguities in Agents.jl. Notice that this resolved a bug with nearby_ids in a no space model which was ambiguous before, all other ambiguities are less important

@Tortar Tortar requested a review from Datseris November 13, 2023 19:26
src/core/space_interaction_API.jl Show resolved Hide resolved
src/spaces/discrete.jl Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Nov 13, 2023

Codecov Report

Merging #921 (c5521ad) into main (fa03585) will increase coverage by 0.00%.
The diff coverage is 60.00%.

❗ Current head c5521ad differs from pull request most recent head 7c14512. Consider uploading reports for the commit 7c14512 to get more accurate results

@@           Coverage Diff           @@
##             main     #921   +/-   ##
=======================================
  Coverage   92.26%   92.26%           
=======================================
  Files          33       33           
  Lines        2274     2275    +1     
=======================================
+ Hits         2098     2099    +1     
  Misses        176      176           
Files Coverage Δ
src/spaces/discrete.jl 98.87% <100.00%> (ø)
src/spaces/grid_single.jl 100.00% <100.00%> (ø)
src/spaces/openstreetmap.jl 89.05% <100.00%> (+0.03%) ⬆️
src/core/space_interaction_API.jl 93.23% <0.00%> (ø)
src/spaces/nothing.jl 70.00% <0.00%> (ø)

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@Tortar
Copy link
Member Author

Tortar commented Nov 13, 2023

I will also add Aqua.jl to the quality tests so expanding a bit the breadth of this PR :-)

@Tortar Tortar changed the title Solve method ambiguities in Agents.jl Add quality code tests: Aqua.jl + method ambiguities test Nov 13, 2023
@Tortar
Copy link
Member Author

Tortar commented Nov 13, 2023

@Datseris Datseris merged commit de82efd into main Nov 14, 2023
6 checks passed
@Datseris Datseris deleted the ambiguities branch November 14, 2023 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants