Skip to content

resolve various ambiguity warnings, fixes #119 #120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 2, 2016
Merged

resolve various ambiguity warnings, fixes #119 #120

merged 1 commit into from
May 2, 2016

Conversation

jrevels
Copy link
Member

@jrevels jrevels commented May 2, 2016

Some method definitions simply needed to be reordered.

@coveralls
Copy link

Coverage Status

Coverage decreased (-1.08%) to 91.266% when pulling 4da5ec3 on jr/ambiguity-fixes into 748c800 on master.

@jrevels
Copy link
Member Author

jrevels commented May 2, 2016

Apparently our overloaded version of promote_array_type is no longer being dispatched to when computing .- during one of our tests, which is causing the test to fail on v0.5.

@KristofferC
Copy link
Collaborator

JuliaLang/julia#16055 maybe related?

@jrevels
Copy link
Member Author

jrevels commented May 2, 2016

That seems likely. I'm going to merge this, then, since the CI failure is unrelated and not on v0.4.

@jrevels jrevels merged commit d723cfc into master May 2, 2016
@jrevels jrevels mentioned this pull request May 8, 2016
Closed
@jrevels jrevels deleted the jr/ambiguity-fixes branch June 15, 2016 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jrevels @coveralls @KristofferC