Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump compat for AbstractDifferentiation to 0.6 #228

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

github-actions[bot]
Copy link
Contributor

This pull request changes the compat entry for the AbstractDifferentiation package from 0.5 to 0.5, 0.6.
This keeps the compat entries for earlier versions.

Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.

@simeonschaub simeonschaub force-pushed the compathelper/new_version/2023-10-13-01-17-14-871-03277491739 branch from 1aa9fc6 to f3dafc7 Compare October 13, 2023 01:17
@oxinabox
Copy link
Member

Yes, I tried this the other day. This fixes a bunch of stuff that was erroring due to getting rid of closures,
Which means we don't need mutation support for basic functioning.
(we still want it, but we don't need it to just support the AD.jl interface)

@oxinabox oxinabox changed the title CompatHelper: bump compat for AbstractDifferentiation to 0.6, (keep existing compat) bump compat for AbstractDifferentiation to 0.6 Oct 13, 2023
@oxinabox
Copy link
Member

Ok I removed the things that were marked as broken that were fixed when i last tried 0.6-DEV
but now new things are failing and I think it will need a little more investigation on what is broken and what extra change has been included in 0.6 since i last looked

@gdalle
Copy link
Member

gdalle commented Jan 16, 2024

@oxinabox happy to help debug the 0.6 changes, this issue recently popped up on discourse

@oxinabox
Copy link
Member

Since I put this on the backburner I have completely forgotten what the more subtle broken things were.

Feel free to take it over @gdalle

@gdalle
Copy link
Member

gdalle commented Jan 16, 2024

I don't know anything about diffractor though, I was mostly talking about problems arising from AbstractDiff. Not sure I can help debug internals over here

@gdalle
Copy link
Member

gdalle commented Jan 16, 2024

also it doesn't help that the Diffractor tests seem to be failing by default?

@oxinabox
Copy link
Member

I think for julia 1.10 they should be working.

@gdalle
Copy link
Member

gdalle commented Jan 16, 2024

I think for julia 1.10 they should be working.

That's only mildly reassuring 🤣

@MasonProtter
Copy link
Contributor

I played with this, and it's quite weird. There's a bunch of things where if I run the tests in the REPL they work fine, but if I do ] test it blows up, including tests that go from passing to failing, and also tests that make the testset fail even though they're locked behind a @test_broken.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants