Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow visit_custom recursion to change the order #179

Merged
merged 2 commits into from
Jul 14, 2023
Merged

Conversation

Keno
Copy link
Collaborator

@Keno Keno commented Jul 8, 2023

To implement order-changing intrinsics.

@codecov
Copy link

codecov bot commented Jul 8, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.03 ⚠️

Comparison is base (efbb0f4) 52.44% compared to head (437aa38) 52.42%.

❗ Current head 437aa38 differs from pull request most recent head 63354cc. Consider uploading reports for the commit 63354cc to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #179      +/-   ##
==========================================
- Coverage   52.44%   52.42%   -0.03%     
==========================================
  Files          27       27              
  Lines        2723     2726       +3     
==========================================
+ Hits         1428     1429       +1     
- Misses       1295     1297       +2     
Impacted Files Coverage Δ
src/stage1/recurse_fwd.jl 57.57% <ø> (ø)
src/tangent.jl 39.23% <ø> (ø)
src/codegen/forward_demand.jl 45.57% <100.00%> (+0.82%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@oscardssmith
Copy link
Member

should we merge this?

@staticfloat
Copy link
Collaborator

@Keno can you add a simple test that changes the order?

Copy link
Member

@oxinabox oxinabox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense.
One comment that is unrelated to the bulk of this

@Keno Keno merged commit 24f047c into main Jul 14, 2023
2 of 4 checks passed
@oscardssmith oscardssmith deleted the kf/visitcustomorder branch July 14, 2023 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants