Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start implementing Cache contexts #587

Merged
merged 5 commits into from
Oct 16, 2024
Merged

Start implementing Cache contexts #587

merged 5 commits into from
Oct 16, 2024

Conversation

gdalle
Copy link
Member

@gdalle gdalle commented Oct 16, 2024

Versions

  • Bump DI to v0.6.15
  • Bump DIT to v0.8.4

DI source

  • Implement Cache <: Context the same way as Constant

DI docs

  • Explain the difference between Cache and Constant
  • Specify which context types are implemented for which backends

DIT source

  • Add a new scenario modified cachify which takes an additional context y_cache where the result is stored before being returned
  • When checking scenario equality, ignore Cache contexts
  • Introduce a new abstract type FunctionModifier for the scenario fiddlers

DI and DIT tests

  • Test cachified scenarios with finite difference backends

@codecov-commenter
Copy link

codecov-commenter commented Oct 16, 2024

Codecov Report

Attention: Patch coverage is 94.44444% with 3 lines in your changes missing coverage. Please review.

Project coverage is 97.57%. Comparing base (d4b17c1) to head (15fec84).

Files with missing lines Patch % Lines
DifferentiationInterface/src/utils/context.jl 60.00% 2 Missing ⚠️
...Ext/DifferentiationInterfaceTestStaticArraysExt.jl 93.75% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #587      +/-   ##
==========================================
- Coverage   97.58%   97.57%   -0.01%     
==========================================
  Files         110      110              
  Lines        5208     5243      +35     
==========================================
+ Hits         5082     5116      +34     
- Misses        126      127       +1     
Flag Coverage Δ
DI 98.59% <60.00%> (-0.06%) ⬇️
DIT 95.70% <97.95%> (+0.12%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gdalle gdalle merged commit 495d988 into main Oct 16, 2024
43 checks passed
@gdalle gdalle deleted the gd/cache branch October 16, 2024 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants