Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't test on 'lts' and 'pre' for draft PRs #391

Merged
merged 12 commits into from
Jul 31, 2024
Merged

Don't test on 'lts' and 'pre' for draft PRs #391

merged 12 commits into from
Jul 31, 2024

Conversation

gdalle
Copy link
Member

@gdalle gdalle commented Jul 30, 2024

CI

  • Add a SHOULDRUN environment variable which is set to true if the PR is ready for review or the Julia version to test is 1
  • Condition every step of the test jobs on SHOULDRUN
  • Trigger CI upon PR being ready for review

DI docs

  • Add CONTRIBUTING.md
  • Restructure "Dev guide", rename "Overloads" to "Implementations"

@codecov-commenter
Copy link

codecov-commenter commented Jul 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.62%. Comparing base (0f7957d) to head (ecf0286).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #391   +/-   ##
=======================================
  Coverage   96.62%   96.62%           
=======================================
  Files         102      102           
  Lines        4974     4974           
=======================================
  Hits         4806     4806           
  Misses        168      168           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gdalle gdalle changed the title Only test on 'lts' and 'pre' if the PR is labeled 'fulltest' Only test on 'lts' and 'pre' for draft PRs Jul 30, 2024
@gdalle gdalle removed the fulltest label Jul 30, 2024
@gdalle gdalle marked this pull request as draft July 30, 2024 16:13
@gdalle gdalle marked this pull request as ready for review July 30, 2024 16:35
@gdalle gdalle changed the title Only test on 'lts' and 'pre' for draft PRs Don't test on 'lts' and 'pre' for draft PRs Jul 30, 2024
@gdalle gdalle merged commit 2ee0b56 into main Jul 31, 2024
51 checks passed
@gdalle gdalle deleted the gd/fasttests branch July 31, 2024 05:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants