-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Batched pushforward, pullback and hvp #320
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #320 +/- ##
==========================================
+ Coverage 96.48% 96.51% +0.03%
==========================================
Files 95 96 +1
Lines 4435 4564 +129
==========================================
+ Hits 4279 4405 +126
- Misses 156 159 +3 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DI source
Batch{B,T}
to wrap anNTuple
, andpick_batchsize(backend, n)
pushforward
,pullback
andhvp
(the seeddx/dy
is aBatch
, and the result too)f
andf!
by splattingf_or_f!y
AutoForwardFromPrimitive
andAutoReverseFromPrimitive
to pretend that a given backend only definesvalue_and_pushforward
/value_and_pullback
=> tests our entire cascade of fallbacksDI extensions
DI.pick_batchsize
with ForwardDiff's internal mechanismpick_batchsize
in Enzyme extensionDI tests
AutoForwardFromPrimitive
+ ForwardDiffAutoReverseFromPrimitive
+ ReverseDiffTODO (in another PR) => see #312
Batch
struct /pick_batchsize
jacobian
orhessian
(will be easier thanks to Revamp test scenarios #323)