Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add type annotations on f in DI #231

Merged
merged 2 commits into from
Apr 29, 2024
Merged

Add type annotations on f in DI #231

merged 2 commits into from
Apr 29, 2024

Conversation

gdalle
Copy link
Member

@gdalle gdalle commented Apr 29, 2024

Core

  • Add f::F and where {F} to the signature of every single operator, in order to force specialization

@codecov-commenter
Copy link

codecov-commenter commented Apr 29, 2024

Codecov Report

Attention: Patch coverage is 97.36842% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 96.13%. Comparing base (cc73842) to head (9167758).
Report is 2 commits behind head on main.

Files Patch % Lines
...fferentiationInterface/src/first_order/pullback.jl 85.71% 1 Missing ⚠️
...rentiationInterface/src/first_order/pushforward.jl 83.33% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #231   +/-   ##
=======================================
  Coverage   96.13%   96.13%           
=======================================
  Files          74       74           
  Lines        3911     3911           
=======================================
  Hits         3760     3760           
  Misses        151      151           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gdalle gdalle merged commit e1e9644 into main Apr 29, 2024
5 checks passed
@gdalle gdalle deleted the gd/annotate branch April 29, 2024 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants