Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

broadcast type preservation #674

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

maartenvd
Copy link

appears to solve the diffractor-zygote case in

FluxML/Zygote.jl#1301

@mcabbott

@mcabbott
Copy link
Member

mcabbott commented Sep 3, 2022

Do you know what the test errors are? Weird it doesn't print them in CI.

Xref comments on testing this a FluxML/Zygote.jl#1302

Edit: note also that https://github.com/JuliaDiff/ChainRules.jl/pull/671/files#r955087897 wants to change CR to use reversed map for this step. A broadcast which iterates backwards would be harder to write.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants