Support for arrays of univariate distributions #14
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With these changes, the following works and gives the same results:
Downside: jacobian computation for r is slower (about 8 times on my laptop) than r2, and allocates more. Why? Because we allocate a vector of Normal each time dist_constructor is called?
Can we do better?
Is it also the case in InferOpt where we do things more similar to r than r2?
TODO:
Edit on performance:
InferOpt seems faster than r2