Ensure string options are converted to proper strings before passing … #204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to ccall Proper fix to #201. The core issue here is that if you take the `pointer` of a SubString, it doesn't properly account for the _substring_ length, because C strings continue until the NUL termination.
Codecov Report
@@ Coverage Diff @@
## main #204 +/- ##
==========================================
- Coverage 64.47% 64.36% -0.11%
==========================================
Files 9 9
Lines 1109 1114 +5
==========================================
+ Hits 715 717 +2
- Misses 394 397 +3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…to ccall
Proper fix to #201. The core issue here is that if you take the
pointerof a SubString, it doesn't properly account for the substring length, because C strings continue until the NUL termination.