Update to Julia v0.6 #32
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
use readbytes!() since readbytes() no longer available
alyst
force-pushed
the
only_update_to_0.6
branch
from
8b40732 to
3d2b5ff
Compare
|
v0.6 tests are ok; fails on nightly due to DataFrames |
nalimilan
reviewed
Nov 4, 2017
REQUIRE
Outdated
| DataFrames 0.7 | ||
| DataArrays 0.3 | ||
| julia 0.6 | ||
| DataFrames 0.10 |
There was a problem hiding this comment.
Is this release really needed? Not that it makes a big difference, but previous versions should also work (if they were ported to 0.6).
src/convert.jl
Outdated
| @@ -40,6 +40,10 @@ function DataArrays.data(ri::RIntegerVector) | |||
| return PooledDataArray(DataArrays.RefArray(refs), pool) | |||
| end | |||
|
|
|||
| # convert R logical vector (uses Int32 to store values) into Vector{Bool[?]} | |||
There was a problem hiding this comment.
Vector{Bool[?]} isn't completely correct, for now it's just DataVector{Bool}. Same in the release notes.
alyst
added a commit
that referenced
this pull request
Nov 4, 2017
|
I've set |
nalimilan
approved these changes
Nov 4, 2017
alyst
force-pushed
the
only_update_to_0.6
branch
from
939c57b to
54d6e2b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-picked from #28: update to Julia v0.6 (support for prior versions dropped), excluding the migration to DataFrames v0.11/CategoricalArrays/Nulls + minor tweaks.
I tried to make the commits atomic, so no squashing is required.
It would allow merging #31.