add optional column indices to completecases #39
Conversation
| @@ -437,12 +437,13 @@ end | |||
| Indexes of complete cases (rows without null values) | |||
|
|
|||
| ```julia | |||
| completecases(dt::AbstractDataTable) | |||
| completecases(dt::AbstractDataTable[, indices]) | |||
| @@ -468,6 +469,9 @@ function completecases(dt::AbstractDataTable) | |||
| res | |||
| end | |||
|
|
|||
| completecases(dt::AbstractDataTable, indices) = completecases(dt[indices]) | |||
|
|
|||
|
|
|||
There was a problem hiding this comment.
A single line break is enough.
| ``` | ||
|
|
||
| **Arguments** | ||
|
|
||
| * `dt` : the AbstractDataTable | ||
| * `indices` : which columns to check for `Null`s |
There was a problem hiding this comment.
Have a look at nonunique for an example of how it's usually documented, I think it's more detailed than that. Also need to say that all columns are used by default. For consistency wit that function, should also accept a single symbol or index.
There was a problem hiding this comment.
Done. In fact I wrote the cols version of nonunique and the associated docstring, so I should have been in a position to get it right the first time around...
| ``` | ||
|
|
||
| **Arguments** | ||
|
|
||
| * `dt` : the AbstractDataTable | ||
| * `cols` : a column indicator (Symbol, Int, Vector{Symbol}, etc.) specifying the column(s) to check for Nulls |
There was a problem hiding this comment.
No uppercase for "null" AFAIK.
There was a problem hiding this comment.
Should also apply code formatting to Symbol, Int, and Vector{Symbol}.
There was a problem hiding this comment.
That's actually an issue in the existing docstrings for similar functions. An additional commits to fix these would be welcome though.
|
will do - should I update dropnull instead or in addition do you think? |
|
I would say in addition. There's also |
mkborregaard
force-pushed
the
complete_cases_for_columns
branch
from
ed41111 to
083e9d0
Compare
|
Bump. |
|
I know! :-) |
mkborregaard
force-pushed
the
complete_cases_for_columns
branch
from
083e9d0 to
b7bc411
Compare
Edited docstring to align with nonunique, and also implemented version when cols is not a Vector
mkborregaard
force-pushed
the
complete_cases_for_columns
branch
from
b7bc411 to
4aa949c
Compare
This is the most barebones possible implementation of the functionality discussed here: #38