Avoid calling vcat(dfs...) in combine() #1261
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This avoids compiling specialized methods for each number of arguments,
which can be very large when using groupby(). The code does not take
advantage at all of that information anyway. The code prior to
refactoring used to do that, by exporting
vcat(::Vector{AbstractDataFrame}). Use an internal method instead since
this is non-standard.
Incidentally, this fixes a small bug introduced in the refactoring: when
working with an empty data frame, vcat() was called, and it returns
Any[0], which surprisingly implied the addition of a bogus x1 column to
the result. The test was actually correct before refactoring.
cjprybol
approved these changes
Oct 16, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids compiling specialized methods for each number of arguments,
which can be very large when using
groupby(). The code does not takeadvantage at all of that information anyway. The code prior to
refactoring used to do that, by exporting
vcat(::Vector{AbstractDataFrame}). Use an internal method instead sincethis is non-standard.
Incidentally, this fixes a small bug introduced in the refactoring: when
working with an empty data frame,
vcat()was called, and it returnsAny[0], which surprisingly implied the addition of a bogusx1column tothe result. The test was actually correct before refactoring.
Refactoring was done at JuliaData/DataTables.jl#45. See also report at https://discourse.julialang.org/t/stack-overflow-in-dataframes-group-by/6357.
Cc: @ExpandingMan