Make collect(::CategoricalArray) return a CategoricalArray
#252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes an inconsistency, as currently `collect(::Type{<:CategoricalValue}, ::AbstractArray)` returns
a `CategoricalArray` but not `collect(::CategoricalArray)`. This is due to the fact that we define
`similar` methods for `Array` but not for ranges, which is what `collect` uses internally.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an inconsistency, as currently
collect(::Type{<:CategoricalValue}, ::AbstractArray)returns aCategoricalArraybut notcollect(::CategoricalArray). This is due to the fact that we definesimilarmethods forArraybut not for ranges, which is whatcollectuses internally.This goes against the
collectdocstring which says that it returns anArray, but we need to override somesimilarmethods anyway for broadcasting to work (#193). This PR is also needed forNamedArrayto return aCategoricalArrayfromnames, as it callscollect(keys(n.dicts[i]))(nalimilan/FreqTables.jl#46).collectseems to be the right abstraction here, but requiring it to return anArrayis not appropriate in all situations.