Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix negative phase margin #962

Merged
merged 4 commits into from
Jan 25, 2025
Merged

Fix negative phase margin #962

merged 4 commits into from
Jan 25, 2025

Conversation

baggepinnen
Copy link
Member

Closes #961

@JuliaControlBot
Copy link

Something failed when generating plots. See the log at https://github.com/JuliaControl/ControlExamplePlots.jl/actions/runs/12962779755?check_suite_focus=true for more details.

@baggepinnen baggepinnen reopened this Jan 25, 2025
@JuliaControlBot
Copy link

This is an automated message.
Plots were compared to references. No changes were detected.

Copy link

codecov bot commented Jan 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.78%. Comparing base (987c0ec) to head (bdbeb80).
Report is 5 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #962   +/-   ##
=======================================
  Coverage   92.78%   92.78%           
=======================================
  Files          41       41           
  Lines        4975     4975           
=======================================
  Hits         4616     4616           
  Misses        359      359           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@baggepinnen baggepinnen merged commit ac6e8fa into master Jan 25, 2025
7 of 10 checks passed
@baggepinnen baggepinnen deleted the negmarg branch January 25, 2025 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

margin() gives incorrect phase margin for system with negative margin
2 participants