Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Build on GitHub Actions #47

Merged
merged 5 commits into from
Jul 31, 2022
Merged

Fix Build on GitHub Actions #47

merged 5 commits into from
Jul 31, 2022

Conversation

LakshyaKhatri
Copy link
Member

Fixes #46

@LakshyaKhatri LakshyaKhatri changed the title Fix: provide keys to actions to make CDSAPI calls Fix Build on GitHub Actions Jul 31, 2022
@LakshyaKhatri LakshyaKhatri marked this pull request as draft July 31, 2022 09:26
@LakshyaKhatri LakshyaKhatri marked this pull request as ready for review July 31, 2022 13:32
@LakshyaKhatri
Copy link
Member Author

Hey @juliohm, sorry for the job failing email spams 🤦🏽‍♂️ 🙂, but this PR will fix the failing jobs.
The reason it's failing here is because GitHub do not allow any new change in the workflow files to access secrets. Right now, accessing secrets here will return empty strings. I tried it on another repository of mine and here are the differences I observed:

Our repo:
Screenshot from 2022-07-31 19-11-55

My other repo:
Screenshot from 2022-07-31 19-09-54

@LakshyaKhatri
Copy link
Member Author

If we choose to merge, kindly squash the commits. I made too many experimental commits in this PR. 🙏 ❤️

@juliohm juliohm merged commit 18eaae8 into JuliaClimate:master Jul 31, 2022
@juliohm
Copy link
Member

juliohm commented Jul 31, 2022

Thank you @LakshyaKhatri for your awesome contributions as usual. I merged it, let's see if it working again. ❤️

@LakshyaKhatri
Copy link
Member Author

🙈 🎉 🕺🏽
Screenshot from 2022-07-31 19-52-13

@juliohm
Copy link
Member

juliohm commented Jul 31, 2022

That is awesome! I will try to trigger the build on master again to see if the badge becomes green.

@LakshyaKhatri
Copy link
Member Author

It still seems to fail for non-linux based platforms!

@juliohm
Copy link
Member

juliohm commented Jul 31, 2022

Yes, I noticed it. Maybe the build is failing on Windows for another reason? Download limits?

@LakshyaKhatri
Copy link
Member Author

Umm, no idea! Mind if I re-open the issue to keep track of this?

@LakshyaKhatri LakshyaKhatri deleted the fix_build_on_github_actions branch July 31, 2022 15:04
@juliohm
Copy link
Member

juliohm commented Jul 31, 2022

Please go ahead. We can comment there that Windows is the only build that is failing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix build on GitHub Actions
2 participants
@LakshyaKhatri @juliohm