Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print headlines in bot report comment #193

Merged
merged 7 commits into from
Jan 7, 2025
Merged

Print headlines in bot report comment #193

merged 7 commits into from
Jan 7, 2025

Conversation

IanButterworth
Copy link
Member

I think it would be helpful to give the headlines in the report comment from the bot.
I haven't run this, but the goal is to look something like the collapsed form of the report.

A more compressed version may be possible.

Screenshot 2024-12-18 at 3 19 13 PM

@IanButterworth
Copy link
Member Author

IanButterworth commented Dec 18, 2024

I can't figure out the error that's happening here.
Ah I see it's addressed/fixed in #190

@maleadt maleadt force-pushed the ib/comment_summary branch from 8656980 to 51d40f5 Compare January 6, 2025 14:19
@IanButterworth
Copy link
Member Author

I wondered if this should be hidden within a collapsed <details> block?

@maleadt
Copy link
Member

maleadt commented Jan 6, 2025

Probably, yes. There's also a relevant CI error.

@IanButterworth
Copy link
Member Author

IanButterworth commented Jan 6, 2025

Is the remaining error new? I see it's on master too

┌ Info: Running as part of test suite, not uploading report
└   message = "upload report for PkgEvalJob JuliaLang/julia@468d5c2 vs. JuliaLang/julia@9a20417"
ERROR: LoadError: NanosoldierError: error when preparing/pushing to report repo: ArgumentError: '/home/runner/.julia/scratchspaces/89f34f1a-2e6b-52eb-a20f-77051b03b735/workdir/NanosoldierReports/pkgeval/by_hash/redacted_vs_redacted' exists. `force=true` is required to remove '/home/runner/.julia/scratchspaces/89f34f1a-2e6b-52eb-a20f-77051b03b735/workdir/NanosoldierReports/pkgeval/by_hash/redacted_vs_redacted' before copying.
Stacktrace:
 [1] nanosoldier_error(msg::String, err::ArgumentError)
   @ Nanosoldier ~/work/Nanosoldier.jl/Nanosoldier.jl/src/error.jl:16
 [2] report(job::PkgEvalJob, results::Dict{Any, Any})
   @ Nanosoldier ~/work/Nanosoldier.jl/Nanosoldier.jl/src/jobs/PkgEvalJob.jl:838
 [3] run(job::PkgEvalJob)
   @ Nanosoldier ~/work/Nanosoldier.jl/Nanosoldier.jl/src/jobs/PkgEvalJob.jl:740
 [4] top-level scope
   @ ~/work/Nanosoldier.jl/Nanosoldier.jl/test/runtests.jl:261
 [5] include(fname::String)
   @ Base.MainInclude ./client.jl:494
 [6] top-level scope
   @ none:6
in expression starting at /home/runner/work/Nanosoldier.jl/Nanosoldier.jl/test/runtests.jl:261

@maleadt maleadt force-pushed the ib/comment_summary branch from bdd12d6 to baf4267 Compare January 7, 2025 07:54
@maleadt maleadt merged commit 116ddae into master Jan 7, 2025
2 checks passed
@maleadt maleadt deleted the ib/comment_summary branch January 7, 2025 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants