Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix airy amplitude scaling #15

Merged
merged 4 commits into from
Mar 29, 2024
Merged

fix airy amplitude scaling #15

merged 4 commits into from
Mar 29, 2024

Conversation

mileslucas
Copy link
Member

@mileslucas
Copy link
Member Author

@sefffal Turns out I had the math completely wrong- this change will be breaking for both the Moffat and Airydisk functions. If you want to give a pull and check it works like you want you can, otherwise I'll merge and register in a day or two.

Copy link

codecov bot commented Mar 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.21%. Comparing base (feaa43c) to head (9abf813).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #15   +/-   ##
=======================================
  Coverage   99.21%   99.21%           
=======================================
  Files           6        6           
  Lines         128      128           
=======================================
  Hits          127      127           
  Misses          1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sefffal
Copy link
Member

sefffal commented Mar 14, 2024

Looks good, thanks for the quick fix @mileslucas!
I haven't done a side by side comparison to see what changed, but the output looks good to me and fixes the issue I noted.

@mileslucas mileslucas merged commit fa89416 into main Mar 29, 2024
11 of 13 checks passed
@mileslucas mileslucas deleted the ml/bug-fixes branch March 29, 2024 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Numerical issue with obscured airy disk
2 participants