Preserve blocking of indices when slicing a unit range with a blocked unit range #465
+55
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #465 +/- ##
==========================================
+ Coverage 93.64% 93.69% +0.04%
==========================================
Files 19 19
Lines 1667 1680 +13
==========================================
+ Hits 1561 1574 +13
Misses 106 106 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
dlfivefifty
requested changes
Jul 1, 2025
| function getindex(r::Base.OneTo{T}, s::BlockedOneTo) where T | ||
| @inline | ||
| @boundscheck checkbounds(r, s) | ||
| return BlockedOneTo(T.(blocklasts(s))) |
There was a problem hiding this comment.
To avoid allocations should this be:
Suggested change
| return BlockedOneTo(T.(blocklasts(s))) | |
| return BlockedOneTo(convert(AbstractVector{T}, blocklasts(s))) |
| return BlockedOneTo(T.(blocklasts(s))) | ||
| end | ||
| function getindex(r::BlockedOneTo{T}, s::BlockedOneTo) where T | ||
| return Base.OneTo(r)[s] |
There was a problem hiding this comment.
To potentially support ∞-arrays I would do:
Suggested change
| return Base.OneTo(r)[s] | |
| return Base.oneto(r)[s] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #367.