Fix similar for Tuple (#51)

* Fix similar for Tuple * Add tests
JuliaAlgebra · Jul 2, 2024 · f9ff304 · f9ff304
1 parent c01cd3f
commit f9ff304
Show file tree

Hide file tree

Showing 3 changed files with 33 additions and 3 deletions.
diff --git a/src/arithmetic.jl b/src/arithmetic.jl
@@ -80,8 +80,8 @@ function MA.operate_to!(
     X::AlgebraElement,
     Y::AlgebraElement,
 )
-    @assert parent(res) === parent(X)
-    @assert parent(X) === parent(Y)
+    @assert parent(res) == parent(X)
+    @assert parent(X) == parent(Y)
     MA.operate_to!(coeffs(res), +, coeffs(X), coeffs(Y))
     return res
 end

diff --git a/src/sparse_coeffs.jl b/src/sparse_coeffs.jl
@@ -42,8 +42,13 @@ function Base.zero(sc::SparseCoefficients)
     return SparseCoefficients(empty(keys(sc)), empty(values(sc)))
 end
 
+_similar(x::Tuple) = _similar(x, typeof(x[1]))
+_similar(x::Tuple, ::Type{T}) where {T} = Vector{T}(undef, length(x))
+_similar(x) = similar(x)
+_similar(x, ::Type{T}) where {T} = similar(x, T)
+
 function Base.similar(s::SparseCoefficients, ::Type{T} = valtype(s)) where {T}
-    return SparseCoefficients(similar(s.basis_elements), similar(s.values, T))
+    return SparseCoefficients(_similar(s.basis_elements), _similar(s.values, T))
 end
 
 function MA.mutability(

diff --git a/test/caching_allocations.jl b/test/caching_allocations.jl
@@ -68,3 +68,28 @@ end
         _alloc_test(YY, +, Y, YY, 2)
     end
 end
+
+@testset "tuple" begin
+    alph = [:a, :b, :c]
+    A★ = FreeWords(alph)
+    B = SA.DiracBasis(A★)
+
+    fB = SA.FixedBasis(B; n = nwords(A★, 2), mt = UInt32(nwords(A★, 2)))
+    fRG = StarAlgebra(A★, fB)
+
+    y = SA.SparseCoefficients(
+        [first(fB)],
+        [1],
+    )
+    Y = AlgebraElement(y, fRG)
+
+    z = SA.SparseCoefficients(
+        (first(fB),),
+        (1,),
+    )
+    Z = AlgebraElement(z, fRG)
+    @test Z + Z == 2 * Z
+    @test Z + Z == Y + Y
+    @test Y + Z == Y + Y
+    @test Z + Y == Y + Y
+end