Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing test URI to the defined ENV variable #30

Merged
merged 2 commits into from
Nov 20, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/base.jl
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
function log_evaluation(logger, performance_evaluation)
function log_evaluation(logger::Logger, performance_evaluation)
experiment = getorcreateexperiment(logger.service, logger.experiment_name;
artifact_location=logger.artifact_location)
run = createrun(logger.service, experiment;
Expand Down
3 changes: 2 additions & 1 deletion src/types.jl
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,8 @@
service = MLFlow(baseuri)

if ~healthcheck(service)
error("It seems that the MLFlow server is not running. For more information, see https://mlflow.org/docs/latest/quickstart.html")
error("It seems that the MLFlow server is not running at specified "*

Check warning on line 37 in src/types.jl

View check run for this annotation

Codecov / codecov/patch

src/types.jl#L37

Added line #L37 was not covered by tests
"location, $baseuri. For more information, see https://mlflow.org/docs/latest/quickstart.html")
end
Logger(service, verbosity, experiment_name, artifact_location)
end
2 changes: 1 addition & 1 deletion test/base.jl
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
@testset verbose = true "base" begin
logger = MLJFlow.Logger("http://localhost:5000";
logger = MLJFlow.Logger(ENV["MLFLOW_URI"];
experiment_name="MLJFlow tests",
artifact_location="/tmp/mlj-test")

Expand Down
2 changes: 1 addition & 1 deletion test/types.jl
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
@testset "types" begin
logger = MLJFlow.Logger("http://localhost:5000")
logger = MLJFlow.Logger(ENV["MLFLOW_URI"])

@test typeof(logger) == MLJFlow.Logger
@test typeof(logger.service) == MLFlow
Expand Down
Loading