-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add EVOware pipetting commands #21
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm very much looking forward to this!
I noticed two changes that are not strictly related to the addition of EVO commands:
- Typo correction in the
ValueError
messages - Enforcing
latin-1
encoding
I think it would be best to do these changes in a separate PR which we can fast-track & merge.
Please add a few basic test cases for the new features. You can run them with pytest -v --cov=robotools --cov-report term-missing robotools/tests.py
to get a report on the line coverage. With the -k SomePartOfTheTestCaseName
you can filter to run tests matching some pattern which is useful too.
I'm keeping my mouth shut over general refactoring changes that I have in mind. But I'll open new issues about them.
Codecov Report
@@ Coverage Diff @@
## master #21 +/- ##
===========================================
- Coverage 97.20% 78.89% -18.32%
===========================================
Files 5 5
Lines 715 938 +223
===========================================
+ Hits 695 740 +45
- Misses 20 198 +178
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
b3cb493
to
dc73d95
Compare
Co-authored-by: Michael Osthege <[email protected]>
Co-authored-by: Michael Osthege <[email protected]>
Co-authored-by: Michael Osthege <[email protected]>
Co-authored-by: Michael Osthege <[email protected]>
Co-authored-by: Michael Osthege <[email protected]>
Co-authored-by: Michael Osthege <[email protected]>
Co-authored-by: Michael Osthege <[email protected]>
656b7b1
to
91cfd04
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Let#s take care of remaining ToDos in follow-up PRs.
This PR aims to implement pipetting commands (as they can be used in the user interface of the EvoWARE) within worklists, i.e. as advanced worklist commands. This enables some pipetting schemes which are not possible with other worklist commands because it allows more precise control over pipetting and wash steps without interference from any grouping shenanigans.