Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate and fix noise issues #12

Merged
merged 4 commits into from
May 11, 2024
Merged

Investigate and fix noise issues #12

merged 4 commits into from
May 11, 2024

Conversation

michaelosthege
Copy link
Member

  • 🐛 Make noise guesses more robust by using standard deviations of the first and last 15 % of the intensity time series.
  • 🐛 Fix posterior predictive sampling and plot such that the actual prediction is shown instead of posterior draws for y.
  • 💡 Add investigative notebook inspecting the effect of likelihood standard deviation (noise) on uncertainty estimates of peak area.

@michaelosthege michaelosthege added bug Something isn't working documentation Improvements or additions to documentation labels May 11, 2024
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@Y0dler Y0dler merged commit c1e5aa1 into main May 11, 2024
4 of 5 checks passed
@Y0dler Y0dler deleted the fix-noise-issues branch May 11, 2024 17:46
@github-actions github-actions bot locked and limited conversation to collaborators May 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants