add ci debugging on macos

JsLth · Nov 7, 2024 · 016452f · 016452f
1 parent c7d8105
commit 016452f
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 9 deletions.
diff --git a/R/new_photon.R b/R/new_photon.R
@@ -57,12 +57,10 @@
 #' # connect to arbitrary server
 #' photon <- new_photon(url = "photonserver.org")
 #'
-#' \donttest{
 #' if (has_java("11")) {
 #' # set up a local instance in the current working directory
-#' photon <- new_photon("photon", country = "Ireland")
-#' photon$remove_data() # cleanup
-#' }}
+#' photon <- new_photon("photon", country = "Monaco")
+#' }
 new_photon <- function(path = NULL,
                        url = NULL,
                        photon_version = NULL,

diff --git a/R/run_photon.R b/R/run_photon.R
@@ -63,6 +63,8 @@ run_start <- function(self, private, args, timeout = 60, quiet = FALSE) {
   start_supervise(self, private, proc, timeout, quiet)
   versionize_logs(private)
   log_error <- assemble_log_error(private$logs)
+  if (is_macos()) print(log_error)
+  abort_log_error(log_error, quiet, class = "start_error")
 
   if (!self$is_running() && !nzchar(log_error)) {
     ph_stop(c( # nocov start
@@ -71,7 +73,7 @@ run_start <- function(self, private, args, timeout = 60, quiet = FALSE) {
     )) # nocov end
   }
 
-  abort_log_error(log_error, quiet, class = "start_error")
+
   cli::cli_progress_done()
   invisible(proc)
 }

diff --git a/man/new_photon.Rd b/man/new_photon.Rd