Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redesigned the Readme doc #6

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jeremybeal11
Copy link
Contributor

I noticed the lessons hopped around which threw me off a bit, so i restructured the page so it it can flow with the lesson a bit better, and i have moved the exercises to the bottom so they can understand it better after reading all of the lessons.

jeremybeal11 added 2 commits September 24, 2018 22:43
made edits to re arrange readme file.
@jeremybeal11
Copy link
Contributor Author

@differentialderek can you give feedback on this?

@dhsorens
Copy link
Contributor

dhsorens commented Oct 3, 2018

I like this organization. It makes sense to me to join the two pizza examples together and keep more theoretical things up at the front. That said, as it is I really like how the examples fit into the flow of the document—feels good to do as you learn. I also like how the original starts with "We learned last time ... " but I'm not really sure where to put the "Receiving before sending" section.

If I'm honest I don't have any strong feelings about the organization. Both make sense to me.

@jeremybeal11
Copy link
Contributor Author

ok thanks @differentialderek, i wanted to get some form of feedback before i resumed issuing my PR. although if not one is complaining then my edits may not be needed.

@JoshOrndorff
Copy link
Owner

feels good to do as you learn

That's what I was going for.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants