Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated specific result/response interface fields from null to current appropriate type #28

Merged

Conversation

newmoneybigbucks
Copy link
Contributor

A number of the response/result interfaces had fields that contained a "null" for their data types, so I went through and changed them to the appropriate type as indicated by the api website and the api data that gets returned. I almost all of them became "null | string" instead of just "null"

…nd string (or whatever is their appropriate data type according to api website)
Copy link

changeset-bot bot commented Mar 8, 2024

🦋 Changeset detected

Latest commit: 52d310e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
tmdb-js-core Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@newmoneybigbucks newmoneybigbucks force-pushed the patchingDataTypeFields branch from 39797e5 to 28a465b Compare March 8, 2024 01:01
@newmoneybigbucks
Copy link
Contributor Author

Got that final formatted ci check sorted out.

@JorrinKievit
Copy link
Owner

Thanks!

@JorrinKievit JorrinKievit merged commit 0de153f into JorrinKievit:master Mar 11, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants