Append to response record fix #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 17, 2024 03:35
…re the never would get distributed over unawanted tyeps when undefined is given to AppendTORespolnseType. Changed it to use an object type instead
🦋 Changeset detectedLatest commit: 722f537 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AppendToReponseType had an issue where if you passed undefined to the MoviesGetDetailsReponse (or the other get details response types) as the required generic parameters (if your using a those types on their own) and then trying to use Omit on it the never would get distributed over all the types of the data fields making the type unsuable. I think this is something to do with Record<string, never> being treated as an index signature, and then when Omit does T[P] never gets put in each place, but I am not 100% on why