Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Lorekeeper::BacktraceCleaner to support BacktraceLocation #41

Merged
merged 2 commits into from
Jan 17, 2024

Conversation

ykitamura-mdsol
Copy link
Collaborator

observing the following error with Ruby3.2 + Rails7.1.2:

undefined method start_with?' for "../ruby/3.2.2/lib/ruby/gems/3.2.0/gems/actionpack-7.1.2/lib/action_dispatch/middleware/debug_exceptions.rb:34:in call'":Thread::Backtrace::Location`

This change was made in Rails (I guess from 7.1.0?):

The result of the backtrace method can be an array of strings or an array of backtrace locations

Adding .to_s like in the PR

@JordiPolo JordiPolo merged commit fbd22ea into master Jan 17, 2024
60 checks passed
@JordiPolo JordiPolo deleted the fix/support_backtrace_location branch January 17, 2024 03:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants