Disable overlap warning for sensors #468
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -689,7 +689,7 @@ impl<'w, 's, C: AnyCollider> NarrowPhase<'w, 's, C> { | |||
| #[cfg(debug_assertions)] | |||
| fn log_overlap_at_spawn( | |||
| collisions: Res<Collisions>, | |||
| added_bodies: Query<(Ref<RigidBody>, Option<&Name>, &Position)>, | |||
| added_bodies: Query<(Ref<RigidBody>, Option<&Name>, &Position), Without<Sensor>>, | |||
There was a problem hiding this comment.
Hmm? Wouldn't the Sensor usually be part of a Collider, which may or may not coincide with being a RigidBody?
I guess this change helps with the case where the RigidBody is holding both the Collider and the Sensor, but does not help with a RigidBody that is the ancestor of a Collider with a Sensor.
There was a problem hiding this comment.
You are right. I thought for some reason that you have to have RigidBody in order for all colliders to work. But now I see that I don't need it and it works without warnings.
Thanks for you comment!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
There is a warning that looks like this:
In my opinion it shouldn't show up when we are spawning
Sensors. They may overlap without explosive behavior.Solution
Sensors are filtered out from the
log_overlap_at_spawnsystem