feat: lazy construction

JonathanWilbur · Aug 30, 2023 · 2d68c1f · 2d68c1f
1 parent 0f90b84
commit 2d68c1f
Show file tree

Hide file tree

Showing 3 changed files with 24 additions and 6 deletions.
diff --git a/source/codecs/ber.ts b/source/codecs/ber.ts
@@ -194,14 +194,17 @@ class BERElement extends X690Element {
     }
 
     set sequence (value: SEQUENCE<ASN1Element>) {
-        this.value = encodeSequence(value);
+        this.construct(value);
         this.construction = ASN1Construction.constructed;
     }
 
     get sequence (): SEQUENCE<ASN1Element> {
         if (this.construction !== ASN1Construction.constructed) {
             throw new errors.ASN1ConstructionError("SET or SEQUENCE cannot be primitively constructed.", this);
         }
+        if (Array.isArray(this._value)) {
+            return this._value;
+        }
         return decodeSequence(this.value);
     }
 
@@ -218,14 +221,17 @@ class BERElement extends X690Element {
     }
 
     set sequenceOf (value: SEQUENCE<ASN1Element>) {
-        this.value = encodeSequence(value);
+        this.construct(value);
         this.construction = ASN1Construction.constructed;
     }
 
     get sequenceOf (): SEQUENCE<ASN1Element> {
         if (this.construction !== ASN1Construction.constructed) {
             throw new errors.ASN1ConstructionError("SET or SEQUENCE cannot be primitively constructed.", this);
         }
+        if (Array.isArray(this._value)) {
+            return this._value;
+        }
         return decodeSequence(this.value);
     }
 

diff --git a/source/codecs/cer.ts b/source/codecs/cer.ts
@@ -214,14 +214,17 @@ class CERElement extends X690Element {
     }
 
     set sequence (value: SEQUENCE<ASN1Element>) {
-        this.value = encodeSequence(value);
+        this.construct(value);
         this.construction = ASN1Construction.constructed;
     }
 
     get sequence (): SEQUENCE<ASN1Element> {
         if (this.construction !== ASN1Construction.constructed) {
             throw new errors.ASN1ConstructionError("SET or SEQUENCE cannot be primitively constructed.", this);
         }
+        if (Array.isArray(this._value)) {
+            return this._value;
+        }
         return decodeSequence(this.value);
     }
 
@@ -239,14 +242,17 @@ class CERElement extends X690Element {
     }
 
     set sequenceOf (value: SEQUENCE<ASN1Element>) {
-        this.value = encodeSequence(value);
+        this.construct(value);
         this.construction = ASN1Construction.constructed;
     }
 
     get sequenceOf (): SEQUENCE<ASN1Element> {
         if (this.construction !== ASN1Construction.constructed) {
             throw new errors.ASN1ConstructionError("SET or SEQUENCE cannot be primitively constructed.", this);
         }
+        if (Array.isArray(this._value)) {
+            return this._value;
+        }
         return decodeSequence(this.value);
     }
 

diff --git a/source/codecs/der.ts b/source/codecs/der.ts
@@ -175,14 +175,17 @@ class DERElement extends X690Element {
     }
 
     set sequence (value: SEQUENCE<ASN1Element>) {
-        this.value = encodeSequence(value);
+        this.construct(value);
         this.construction = ASN1Construction.constructed;
     }
 
     get sequence (): SEQUENCE<ASN1Element> {
         if (this.construction !== ASN1Construction.constructed) {
             throw new errors.ASN1ConstructionError("SET or SEQUENCE cannot be primitively constructed.", this);
         }
+        if (Array.isArray(this._value)) {
+            return this._value;
+        }
         return decodeSequence(this.value);
     }
 
@@ -200,14 +203,17 @@ class DERElement extends X690Element {
     }
 
     set sequenceOf (value: SEQUENCE<ASN1Element>) {
-        this.value = encodeSequence(value);
+        this.construct(value);
         this.construction = ASN1Construction.constructed;
     }
 
     get sequenceOf (): SEQUENCE<ASN1Element> {
         if (this.construction !== ASN1Construction.constructed) {
             throw new errors.ASN1ConstructionError("SET or SEQUENCE cannot be primitively constructed.", this);
         }
+        if (Array.isArray(this._value)) {
+            return this._value;
+        }
         return decodeSequence(this.value);
     }