Fix GH#25048: Export Tempo as system text in MusicXML #689
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jojo-Schmitz
force-pushed
the
3.x-xml/systemtempo
branch
3 times, most recently
from
6f48ffa
to
4cdb621
Compare
Jojo-Schmitz
force-pushed
the
3.x-xml/systemtempo
branch
from
4cdb621
to
1019f23
Compare
Jojo-Schmitz
commented
Nov 8, 2024
| _xml.stag(QString("direction placement=\"%1\"").arg((text->placement() == Placement::BELOW ) ? "below" : "above")); | ||
| QString tempoAttrs = QString("direction placement=\"%1\"").arg(text->placement() == Placement::BELOW ? "below" : "above"); | ||
| if (text->systemFlag()) | ||
| tempoAttrs += QString(" system=\"%1\"").arg(text->isLinked() ? "also-top" : "only-top"); |
There was a problem hiding this comment.
This "also-top" seems to never happen with Mu3 ?!?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of musescore#25312
Resolves: musescore#25048 and and musescore#17431