Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

free disk space for MacOS CI compilation #129

Merged
merged 1 commit into from
Jun 16, 2023

Conversation

AntonioBL
Copy link

Trying to solve the packaging problem with Qt5.15.2

Some softwares of the virtual machine not directly used for the compilation were deleted.

  • I signed the CLA
  • The title of the PR describes the problem it addresses
  • Each commit's message describes its purpose and effects, and references the issue it resolves
  • If changes are extensive, there is a sequence of easily reviewable commits
  • The code in the PR follows the coding rules
  • There are no unnecessary changes
  • The code compiles and runs on my machine, preferably after each commit individually
  • I created a unit test or vtest to verify the changes I made (if applicable)

@AntonioBL
Copy link
Author

AntonioBL commented Jun 14, 2023

Ah, because of github new rules, since I am a new contributor to the unofficial MuseScore 3.7 (MuseJojo or JojoScore? 😝 ), the workflow run must be approved by a maintainer. 😅

@Jojo-Schmitz
Copy link
Owner

Done 😉

@AntonioBL
Copy link
Author

AntonioBL commented Jun 14, 2023

Thank you 😃
There was a compilation problem due to dependencies overwriting in HomeBrew. It was not caused by my modifications, but probably by a very recent HomeBrew update.
I tried a workaround similar to the one used before.

... And workflows still need manual trigger 😅

@Jojo-Schmitz
Copy link
Owner

As I'm currently away from my computer, I'll check all this when I'm back, on the weekend probably

@Jojo-Schmitz
Copy link
Owner

Oops. I needed to approve again, done now

@AntonioBL
Copy link
Author

Ok, now everything should be solved.
The real change is the size of the (virtual) disk unit set by hdiutil. Then I left the instructions reclaiming some ("real") disk space (it can be useful) and I patched the compilation after the updates of HomeBrew.

...Well, workflows have to be approved again 😅 , but the resulting artifact should work ok.

@Jojo-Schmitz
Copy link
Owner

Jojo-Schmitz commented Jun 16, 2023

Can you please explain (again?) why this is needed?

Ah, I see, the problem that #93 tries to fix by downgrading Qt...

@Jojo-Schmitz Jojo-Schmitz merged commit 41c7096 into Jojo-Schmitz:3.x Jun 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants