Skip to content

Commit

Permalink
Disable Feedback and Check for updates
Browse files Browse the repository at this point in the history
as neither works or is provided by this fork
  • Loading branch information
Jojo-Schmitz committed Sep 17, 2024
1 parent 4f02df4 commit e3b3aa2
Show file tree
Hide file tree
Showing 6 changed files with 20 additions and 4 deletions.
14 changes: 13 additions & 1 deletion mscore/musescore.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1310,6 +1310,7 @@ MuseScore::MuseScore()
fotoTools->setObjectName("foto-tools");
fotoTools->addWidget(new AccessibleToolButton(fotoTools, getAction("fotomode")));

#if 0
//-------------------------------
// Feedback Tool Bar
//-------------------------------
Expand All @@ -1329,6 +1330,7 @@ MuseScore::MuseScore()
feedbackButton->setToolButtonStyle(Qt::ToolButtonTextBesideIcon);
feedbackTools->addWidget(feedbackButton);
}
#endif

addToolBarBreak();

Expand Down Expand Up @@ -1556,11 +1558,13 @@ MuseScore::MuseScore()
connect(entryTools, SIGNAL(visibilityChanged(bool)), a, SLOT(setChecked(bool)));
menuToolbars->addAction(a);

#if 0
a = getAction("toggle-feedback");
a->setCheckable(true);
a->setChecked(feedbackTools->isVisible());
connect(feedbackTools, SIGNAL(visibilityChanged(bool)), a, SLOT(setChecked(bool)));
menuToolbars->addAction(a);
#endif

a = getAction("toggle-workspaces-toolbar");
a->setCheckable(true);
Expand Down Expand Up @@ -1900,7 +1904,7 @@ MuseScore::MuseScore()
Workspace::addActionAndString(aboutMusicXMLAction, "about-musicxml");

#if defined(Q_OS_MAC) || defined(Q_OS_WIN)
#if (!defined(FOR_WINSTORE)) && (!defined(WIN_PORTABLE))
#if (!defined(FOR_WINSTORE)) && (!defined(WIN_PORTABLE) && 0)
checkForUpdateAction = new QAction("", 0);
connect(checkForUpdateAction, SIGNAL(triggered()), this, SLOT(checkForUpdatesUI()));
checkForUpdateAction->setMenuRole(QAction::NoRole);
Expand All @@ -1922,11 +1926,13 @@ MuseScore::MuseScore()
menuHelp->addAction(reportBugAction);
Workspace::addActionAndString(reportBugAction, "report-bug");

#if 0
leaveFeedbackAction = new QAction("", 0);
connect(leaveFeedbackAction, &QAction::triggered, this, [this]{ leaveFeedback("menu"); });
leaveFeedbackAction->setMenuRole(QAction::NoRole);
menuHelp->addAction(leaveFeedbackAction);
Workspace::addActionAndString(leaveFeedbackAction, "leave-feedback");
#endif

menuHelp->addSeparator();
menuHelp->addAction(getAction("resource-manager"));
Expand Down Expand Up @@ -2122,15 +2128,19 @@ void MuseScore::retranslate()
checkForUpdateAction->setText(tr("Check for &Update"));
askForHelpAction->setText(tr("Ask for Help"));
reportBugAction->setText(tr("Report a Bug"));
#if 0
leaveFeedbackAction->setText(tr("Feedback"));
#endif
revertToFactoryAction->setText(tr("Revert to Factory Settings"));

fileTools->setWindowTitle(tr("File Operations"));
transportTools->setWindowTitle(tr("Playback Controls"));
cpitchTools->setWindowTitle(tr("Concert Pitch"));
fotoTools->setWindowTitle(tr("Image Capture"));
entryTools->setWindowTitle(tr("Note Input"));
#if 0
feedbackTools->setWindowTitle(tr("Feedback"));
#endif
workspacesTools->setWindowTitle(tr("Workspaces"));

// keep translatable (con)texts in sync with those from zoombox.cpp
Expand Down Expand Up @@ -6379,8 +6389,10 @@ void MuseScore::cmd(QAction* a, const QString& cmd)
fotoTools->setVisible(!fotoTools->isVisible());
else if (cmd == "toggle-noteinput")
entryTools->setVisible(!entryTools->isVisible());
#if 0
else if (cmd == "toggle-feedback")
feedbackTools->setVisible(!feedbackTools->isVisible());
#endif
else if (cmd == "toggle-workspaces-toolbar")
workspacesTools->setVisible(!workspacesTools->isVisible());
else if (cmd == "create-new-workspace") {
Expand Down
2 changes: 2 additions & 0 deletions mscore/musescore.h
Original file line number Diff line number Diff line change
Expand Up @@ -254,7 +254,9 @@ class MuseScore : public QMainWindow, public MuseScoreCore {
QToolBar* fileTools;
QToolBar* transportTools;
QToolBar* entryTools;
#if 0
QToolBar* feedbackTools;
#endif
QToolBar* workspacesTools;
TextTools* _textTools { 0 };
PianoTools* _pianoTools { 0 };
Expand Down
2 changes: 1 addition & 1 deletion mscore/musescoredialogs.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -159,7 +159,7 @@ AboutBoxDialog::AboutBoxDialog()
setWindowFlags(this->windowFlags() & ~Qt::WindowContextHelpButtonHint);

QString visitAndDonateString;
#if !defined(FOR_WINSTORE)
#if !defined(FOR_WINSTORE) && 0
visitAndDonateString = tr("Visit %1 for new versions and more information.\nGet %2help%3 with the program or %4contribute%5 to its development.")
.arg("<a href=\"https://www.musescore.org/\">www.musescore.org</a>",
"<a href=\"https://www.musescore.org/forum\">", "</a>",
Expand Down
2 changes: 1 addition & 1 deletion mscore/preferences.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ void Preferences::init(bool storeInMemoryOnly)

_storeInMemoryOnly = storeInMemoryOnly;

#if defined(Q_OS_MAC) || (defined(Q_OS_WIN) && !defined(FOR_WINSTORE))
#if defined(Q_OS_MAC) || (defined(Q_OS_WIN) && !defined(FOR_WINSTORE) && 0)
bool checkUpdateStartup = true;
bool checkExtensionsUpdateStartup = true;
#else
Expand Down
2 changes: 1 addition & 1 deletion mscore/prefsdialog.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -265,7 +265,7 @@ PreferenceDialog::PreferenceDialog(QWidget* parent)
connect(resetPreference, &QPushButton::clicked, this, &PreferenceDialog::resetAdvancedPreferenceToDefault);
connect(this, &PreferenceDialog::preferencesChanged, mscore->timeline(), &Timeline::updateTimelineTheme); // this should probably be moved to updateUiStyleAndTheme
MuseScore::restoreGeometry(this);
#if !defined(Q_OS_MAC) && (!defined(Q_OS_WIN) || defined(FOR_WINSTORE))
#if !defined(Q_OS_MAC) && (!defined(Q_OS_WIN) || defined(FOR_WINSTORE)) || !0
General->removeTab(General->indexOf(tabUpdate)); // updateTab not needed on Linux and not wanted in Windows Store
#endif
}
Expand Down
2 changes: 2 additions & 0 deletions mscore/shortcut.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -2168,13 +2168,15 @@ Shortcut Shortcut::_sc[] = {
QT_TRANSLATE_NOOP("action","Note Input"),
QT_TRANSLATE_NOOP("action","Toggle 'Note Input' toolbar")
},
#if 0
{
MsWidget::MAIN_WINDOW,
STATE_NORMAL | STATE_NOTE_ENTRY | STATE_EDIT ,
"toggle-feedback",
QT_TRANSLATE_NOOP("action","Feedback"),
QT_TRANSLATE_NOOP("action","Toggle 'Feedback' toolbar"),
},
#endif
{
MsWidget::MAIN_WINDOW,
STATE_NORMAL | STATE_NOTE_ENTRY | STATE_EDIT ,
Expand Down

0 comments on commit e3b3aa2

Please sign in to comment.