Skip to content

Commit

Permalink
Raise macOS deployment target to 10.13
Browse files Browse the repository at this point in the history
Sort of backporting musescore#19570
  • Loading branch information
cbjeukendrup authored and Jojo-Schmitz committed Sep 14, 2024
1 parent 10d1b80 commit 1dadcc4
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 6 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/build_macos.yml
Original file line number Diff line number Diff line change
Expand Up @@ -35,11 +35,11 @@ on:

env:
CURRENT_RELEASE_BRANCH: 3.x
DEVELOPER_DIR: /Applications/Xcode_13.1.app/Contents/Developer
DEVELOPER_DIR: /Applications/Xcode_15.1.app/Contents/Developer

jobs:
macos:
runs-on: macos-12
runs-on: macos-13
steps:
- name: Cancel Previous Runs
uses: styfle/[email protected]
Expand Down
4 changes: 2 additions & 2 deletions CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -210,8 +210,8 @@ if (APPLE)
set (CMAKE_CXX_COMPILER_ID "Clang")
set(CMAKE_OSX_ARCHITECTURES x86_64)

set(MACOSX_DEPLOYMENT_TARGET 10.10)
set(CMAKE_OSX_DEPLOYMENT_TARGET 10.10)
set(MACOSX_DEPLOYMENT_TARGET 10.13)
set(CMAKE_OSX_DEPLOYMENT_TARGET 10.13)

set(HAS_AUDIOFILE TRUE) # Requires libsndfile
set(MAC_APPCAST_URL "")
Expand Down
2 changes: 1 addition & 1 deletion build/MacOSXBundleInfo.plist.in
Original file line number Diff line number Diff line change
Expand Up @@ -447,7 +447,7 @@
<key>LSRequiresCarbon</key>
<true/>
<key>LSMinimumSystemVersion</key>
<string>10.10.0</string>
<string>${MACOSX_DEPLOYMENT_TARGET}</string>
<key>NSHumanReadableCopyright</key>
<string>${MACOSX_BUNDLE_COPYRIGHT}</string>
<key>LSApplicationCategoryType</key>
Expand Down
2 changes: 1 addition & 1 deletion build/ci/macos/setup.sh
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ echo "Setup MacOS build environment"
trap 'echo Setup failed; exit 1' ERR
SKIP_ERR_FLAG=true

export MACOSX_DEPLOYMENT_TARGET=10.10
export MACOSX_DEPLOYMENT_TARGET=10.13

# install dependencies
wget -c --no-check-certificate -nv -O bottles.zip https://musescore.org/sites/musescore.org/files/2020-02/bottles-MuseScore-3.0-yosemite.zip
Expand Down

0 comments on commit 1dadcc4

Please sign in to comment.