-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve reputation miner user experience #1160
Open
chmanie
wants to merge
9
commits into
develop
Choose a base branch
from
feature/rep-miner-ux
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chmanie
force-pushed
the
feature/rep-miner-ux
branch
from
August 30, 2023 14:44
ee72c3c
to
57ecf1d
Compare
The commit I've added pages the previous mining cycles on syncing. This is exactly the same issue that we were facing in the frontend in a few different areas that Raul fixed. The same solution is done here - instead of asking for all events in one big request, we split it up in to multiple requests and join all the responses together. |
chmanie
force-pushed
the
feature/rep-miner-ux
branch
from
September 17, 2023 16:17
4a0de48
to
b2c8515
Compare
chmanie
force-pushed
the
feature/rep-miner-ux
branch
from
September 18, 2023 11:24
cca9cd9
to
1e75b3f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does the following:
Arguments to the reputation miner client executable are simplified and described better. Removed:
network
,localProviderAddress
,localPort
,providerAddress
, all in favor ofrpcEndpoint
Almost all arguments got sensible defaults. Now only
privateKey
orminerAddress
have to be specified.All arguments have corresponding environment variables with the
REP_MINER
prefix (e.g.privateKey
isREP_MINER_PRIVATE_KEY
)The docker image got adjusted to that (and also should yield a more consistent build)
The whole configuration is shown when the reputation miner is started
All docs are adjusted to the new arguments and workflow
In the docs, the possibility to stake for reputation mining was added (directly from a form in the docs)
Alex fixed two issues that were related to first time miners.